[PATCH] Fix win32 command processor quoting in system() calls

Alexis S. L. Carvalho alexis at cecm.usp.br
Fri Dec 15 21:26:10 UTC 2006


Thus spake Patrick Mezard:
> Fix win32 command processor quoting in system() calls.

This is http://www.selenic.com/mercurial/bts/issue397 .

> Win32 command processor does strange things regarding quotes. Sometimes, it
> just strips the leading and ending command quotes. Try to anticipate this
> behaviour documented in CMD.EXE man page, and add quotes preventively.

I've attached a patch to that issue, but it hasn't attracted any
testers.  Could you give it a try?

http://www.selenic.com/mercurial/bts/file226/system.patch

That patch always adds an additional pair of quotes to the command line,
without trying to figure out if cmd.exe will remove them or not.  I
/think/ it should work, but it really needs some real testing...

Alexis



More information about the Mercurial-devel mailing list