[PATCH] version: always overwrite __version__

[Matt Mackall]

On Tue, Feb 06, 2007 at 08:24:38PM +0100, Christian Ebert wrote:
> * Alexis S. L. Carvalho on Tuesday, February 06, 2007 at 16:06:53 -0200:
> > Thus spake Christian Ebert:
> >> version: always overwrite __version__
> > 
> > I've pushed a different fix to crew-stable - the "don't overwrite if it
> > hasn't changed" logic was added back in 7eb694a1c1af, so I thought it
> > was better to keep it.
> 
> But have you tried my test with your patch? I experimented with
> reload too, but, at least here, this doesn't change anything.
> That's why, in practice, I've found no other way to adapt the
> version on first run but by always overwriting.
> 
> See also issue460, or
> Message-ID: <9246b6b50612221117i9e84d56ge27f9d69bbcf9e7 at mail.gmail.com>
> in the mercurial list.
> 
> And, AFAICS, nothing besides setup.py actually calls
> rememberversion(), so there's no overhead in runtime, and
> shouldn't the main purpose of a version script be that it returns
> the right version?

I think that we should actually move all the logic to setup.py and
simply directly write a version string in version.py. Simpler all around.

-- 
Mathematics is the supreme nostalgia of our time.