[PATCH] Don't lie that "binary file has changed"
Alexis S. L. Carvalho
alexis at cecm.usp.br
Fri Feb 16 07:31:36 UTC 2007
Thus spake tailgunner at smtp.ru:
> On Thu, 15 Feb 2007 09:19:12 -0200
> "Alexis S. L. Carvalho" <alexis at cecm.usp.br> wrote:
> > Do you have an example of when unidiff is called for two identical
> > (binary) files?
> >
>
> The case where binary file is renamed
Ah, true - but we only detect renames when generating --git patches, and
in this case we shouldn't call unidiff. I've pushed changeset
4ced663bebf0 to crew-stable to fix this.
> > Comparing a and b directly would probably be even faster :)
> >
>
> Sure, but it would take twice as much memory
We already have both strings in memory...
Alexis
More information about the Mercurial-devel
mailing list