Win32 tests status on crew-stable, synchronization with crew

Patrick Mézard pmezard at gmail.com
Sun May 6 10:48:25 UTC 2007


Hello,

I have rebased win32 unit test patch queue from crew to crew-stable. 
Several changesets/fixes were imported from crew. Could they be pushed 
in crew-stable ?


1- The following tests fail on crew-stable but not in crew:
-----------------------------------------------------------

- test-init: fails because the following changesets were not imported 
from crew :
	* caaba589d9c79750d2d74295178cb7b5abe7936f Use patch.patch() when 
checking for patch availability.
	* 8c2a18cc3096dd300d196c2b960e8e91fbf6791a Fix
find_in_path not including some file extension logic under win32.

I do not think they are doing much harm but the failure is not really 
important either (cannot find gpatch) and is unlikely to hide something 
else.

- test-hgignore: fails because
"""
ERROR: test-hgignore output changed
--- Expected output
+++ Test output
@@ -10,6 +10,8 @@
  A dir/b.o
  ? .hgignore
  ? a.c
+? a.o
+? dir/c.o
  ? syntax
  --
  .hgignore: ignoring invalid syntax 'invalid'
"""
I think it comes from:
	* a7cae4e22749610bff70b41163fc0b421f97508a Pass normalized directory 
names to the ignore function

But it depends on many other changesets (mostly Alexis file matcher 
patches). I do not think there is an easy way to fix this in crew-stable.



2- Changesets were imported from crew to make other tests to pass
-----------------------------------------------------------------
Most of them are test-related and should not impact anything else that 
test code. They are real improvements over crew-stable tests. Besides, 
keeping tests synchronized between crew and crew-stable reduces the 
maintenance cost for the win32 patches

- Import simplemerge and related tests: there is no merge tool under 
win32. The import is simple, it's only dependencies are one 3-lines 
function in diff.py and a fix to an i18n import in simplemerge itself.
Also import 46280c004f22 "change tests to use simplemerge by default".

- Import printenv.py. Test helper, improve tests portability.

- Import several changes replacing helper shell scripts with python ones.

- Use crew run-test.py. No impact whatsoever given simplemerge is 
already imported.

- Import 6ea8a3b805ee "Flush stderr after write". This changeset was 
introduced in crew to fix win32 tests.

- Import bbdba01cce28 "Enforce unixish style for all generated patch 
names." Also introduced to fix win32 crew tests.

--
Patrick Mézard



More information about the Mercurial-devel mailing list