[PATCH] mercurial.el: fix error on hg-read-rev() with small tip, and cleanups
Brendan Cully
brendan at kublai.com
Wed May 9 18:32:22 UTC 2007
On Monday, 07 May 2007 at 21:48, NIIMI Satoshi wrote:
> # HG changeset patch
> # User NIIMI Satoshi <sa2c at sa2c.net>
> # Date 1178541851 -32400
> # Node ID 3c890a932a2e75eee2e836ca9cced90b1a5cb3f7
> # Parent f1b66a95c2ae648c8fed08cf58a43766010abd54
> mercurial.el: fix error on hg-read-rev() with small tip, and cleanups
>
> * Fix error if tip revision is smaller than hg-rev-completion-limit
>
> If tip revision is 10, "hg log -r -100:tip" fails.
>
> * Remove dependencies on cl package at runtime
>
> Quote from GNU Emacs Lisp Reference Manual, Emacs Lisp Coding Conventions:
> > * Please don't require the `cl' package of Common Lisp extensions at
> > run time. Use of this package is optional, and it is not part of
> > the standard Emacs namespace. If your package loads `cl' at run
> > time, that could cause name clashes for users who don't use that
> > package.
>
> * Check XEmacs at compile time
>
> Since byte-compiled file is not portable between GNU Emacs and
> XEmacs, checking type of emacs can be done at compile time. This
> reduces byte-compiler warnings.
>
> * Defvar variables binded dynamically and used across functions
>
> * Combine status output string to state symbol alist into a variable,
> and use char instead of string for key of state alist
>
> * Make hg-view-mode as minor-mode
>
> * Define keymaps as conventions
Pushed, thanks. But it would have been nice if you'd split the patch
into pieces (say one for each bullet point here).
More information about the Mercurial-devel
mailing list