[PATCH 2 of 5] Add ability to parse branch information to hg import

[Eric M. Hopper]

On Thu, 2007-05-17 at 10:31 -0700, Brendan Cully wrote:
> >          return None, message, user, date, None, None, None
> 
> hmm, looks like you might not have caught all the return cases?

You're right, and I've fixed it.

> >      p1 = parents and parents.pop(0) or None
> >      p2 = parents and parents.pop(0) or None
> > -    return tmpname, message, user, date, nodeid, p1, p2
> > +    return tmpname, message, user, date, branch, nodeid, p1, p2
> 
> (this tuple is getting a bit long too - it might be worth turning it
> into a class or at least dict at some point...)

Perhaps this is true, though I would prefer not to have to fix it to get
this patch accepted.

In truth, the import export mechanism needs even slightly more of an
overhaul.  It's possible to have a change that simply consists of
starting a new branch with no other change at all.  I do not believe
that this can currently be handled properly by the import export
mechanism.

I will be re-submitting the patches not yet accepted shortly with a
couple of small changes designed to fix the problems you noticed.

Thanks,
-- 
The best we can hope for concerning the people at large is that they
be properly armed.  -- Alexander Hamilton
-- Eric Hopper (hopper at omnifarious.org  http://www.omnifarious.org/~hopper) --
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 185 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20070517/3136434a/attachment.asc>