[PATCH 2 of 2] osutil.c: replace alloca() with malloc() and remove <alloca.h>
Benoit Boissinot
benoit.boissinot at ens-lyon.org
Sun Oct 7 21:56:01 UTC 2007
On Mon, Oct 08, 2007 at 12:43:09AM +0300, Giorgos Keramidas wrote:
> On 2007-10-07 23:26, Benoit Boissinot <bboissin at gmail.com> wrote:
> >On 10/7/07, Giorgos Keramidas <keramida at ceid.upatras.gr> wrote:
> >> The <alloca.h> header is not really portable, and it breaks Mercurial on
> >> FreeBSD. Remove the dependency on <alloca.h> and alloca() by replacing
> >> the only place where it was used with malloc().
> >
> > Have you done a performance test to see wether it has an impact or not ?
>
> Not really, how should I go about testing that this is not a performance
> regression? I ssuspect there's going to be a minor overhead because of
> an extra function call for the free() I added, but it would be nice to
> be able to produce useful performance test results.
>
hg status on a huge repo ?
--
:wq
More information about the Mercurial-devel
mailing list