[PATCH] Re: crew fails to build on Solaris

[Matt Mackall]

On Fri, Oct 12, 2007 at 12:45:44PM -0700, Bryan O'Sullivan wrote:
> Giorgos Keramidas wrote:
> 
> > osutil.c: DIR->dd_fd is not a public interface on Solaris
> 
> The original code builds just fine on Solaris 10.  It would be useful to 
> know when that stuff was introduced into Solaris, so the ifdefs can be 
> more carefull parameterised.

I've dropped the fstatat bits in the current tip for now under the
theory that they weren't worth the trouble. But it seems they're a
non-negligible performance improvement here, so they ought to go back
in if we can figure out how to make it build everywhere.

with lstat:
 real    0m1.094s
 user    0m0.728s
 sys     0m0.360s

with fstatat:
 real    0m0.957s
 user    0m0.772s
 sys     0m0.180s

That's a 15% improvement. Oddly, there's a 2x reduction in system time
but an increase in user time.

-- 
Mathematics is the supreme nostalgia of our time.