[RFC] branchview-NG
Dirkjan Ochtman
dirkjan at ochtman.nl
Tue Jun 17 19:43:34 UTC 2008
Matt Mackall wrote:
> I think a reasonable JSON encoder can be something like 20-30 lines.
Right. I added one this time around.
> Ok, you should probably update glog to use graphmod then.
glog is seriously hairy and I'd like to ask Joel Rosdahl to take a look
before I spend a lot of time on it. I also think that, while I want to
push consolidation, this shouldn't stop us from merging the graph.
> - it should probably say "graph" rather than "revision graph"
> - it uses a really long date
> - it uses the full username
> - it's missing the thin ruling lines
Fixed all of these to be more consistent with shortlog.
> - it shows the hash (which would probably be better as a tooltip here
> and in shortlog)
I kept the hash because I wanted something which I could color; I
couldn't use the description for that because I wanted to make that link
to the actual changeset. I'm certainly interested in other ideas.
> - it doesn't have the row coloring (maybe with good reason, but I'd
> like to see them)
I didn't see this in shortlog, either. I also think it's not a good fit
with the other coloring we have going on. But you're welcome to experiment.
> Maybe. But at any rate, it should be seen as an alternate view of the
> shortlog. In particular, it should have changeset and browse buttons.
> Toggling between log and graph should change as little as possible,
> visually, at least in the coal and paper styles. That may even mean
> dropping the author and date in this view (or moving them to tool tips)
> so that everything is one line high.
I put in changeset and browse buttons. With the shortened user and date,
I think we don't need to move them into a tooltip, as it looks much less
cluttered now and is very nice on the eyes.
> Also, FYI, I'm intending to make paper the default theme.
I thought as much. I think having the menu on the left is certainly an
improvement (and we should do that for coal, as well), but I think paper
is a little to grey for my taste currently.
Cheers,
Dirkjan
More information about the Mercurial-devel
mailing list