[PATCH 2 of 8] Add a method to dirstate to return case folding state
Paul Moore
p.f.moore at gmail.com
Thu May 1 08:23:00 UTC 2008
2008/5/1 Dirkjan Ochtman <dirkjan at ochtman.nl>:
> Adrian Buehlmann wrote:
> > Post the whole series again -- but not now. Maybe next week.
>
> Er, why not now? That makes no sense.
I agree.
> Paul, I also agree that foldspath is not a very good method name; I
> think something making clear that it is related to checkfolding might be
> nice (so something like "folding") -- but it's a bit of a bikeshed.
Adrian's point that it won't be case-related if a Mac OS
implementation gets added is a good one. I'll send a replacement using
"pathfolding". Hopefully today.
> I think the patch queue looks solid and I feel you've thoroughly
> researched the issue. It would be nice if some other crew member spoke
> up to say what they think of all this, though, before I push it.
Thanks. I would also be interested in other views - I intend to keep
working on Windows issues, so the more comments I get now, the better
I'll be able to get things right in the future!
Paul
PS I missed this when writing up the email headers etc, but this
series is also a fix for issue 912.
More information about the Mercurial-devel
mailing list