[PATCH 3 of 3] color: removed --no-color, added auto colorization

Paul Moore p.f.moore at gmail.com
Wed Nov 12 23:03:07 UTC 2008


2008/11/12 Brodie Rao <dackze at gmail.com>:
>> Does this work on Windows (where ANSI colour codes are not supported,
>> but there is no TERM environment variable)?
>
> In that case it would output the control codes anyway, like the color
> extension acts right now. I don't think special casing Windows would
> make sense. What if someone's using rxvt on Windows?
>
> The extension's documentation says it uses ANSI control codes, but it
> doesn't specifically mention that the Windows command prompt doesn't
> support them. Maybe that could be clarified?

Fair enough - I don't use the extension, so I didn't realise it
behaved like that at the moment. In that case, your patch doesn't make
things any worse, so I don't see any reason to worry about it.

Paul.



More information about the Mercurial-devel mailing list