[PATCH 2 of 2] keyword: get changectx via linkrev

Dirkjan Ochtman dirkjan at ochtman.nl
Sat Nov 15 01:06:45 UTC 2008


Christian Ebert wrote:
> # HG changeset patch
> # User Christian Ebert <blacktrash at gmx.net>
> # Date 1226698144 -3600
> # Node ID b91737072d59bb21ba8c2f784d175ae55985648b
> # Parent  b556a8831c9173b48ad83d5a4bcf345c2f0038e9
> keyword: get changectx via linkrev

... but I really don't see the point in this. Adding the getctx() 
method, to me, seems like an unneeded addition, when the underlying code 
really is a one-liner. Additionally, doing this through the ctx/fctx 
code provides an additional abstraction that can take care of things 
(like the linkrev optimization) for you.

Cheers,

Dirkjan




More information about the Mercurial-devel mailing list