[PATCH] osutil.c: Win32 implementation with review notes from crew incorporated
Adrian Buehlmann
adrian at cadifra.com
Thu Sep 11 09:51:01 UTC 2008
On 11.09.2008 05:32, Matt Mackall wrote:
> On Wed, 2008-09-10 at 13:45 -0400, Petr Kodl wrote:
>> + if (PyList_Sort(list))
>> + goto error_file;
>
> Similar arguments apply here. But we actually don't even want to sort at
> this level anyway.
Both the unix C implementation and the default python implementation of
listdir [1] currently _do_ sort the list.
Now Petr has removed the sorting altogether from the Windows implementation
of listdir in his newest version of the patch he sent to this list.
I thought the sorting was one of the main speedup reasons for what bos
contributed?
So should the sorting now be removed from listdir or what?
This is again very confusing.
Maybe I'm just too dumb to read and comment here, but it would help
a lot if comments could be a bit more explicit.
[1] http://selenic.com/repo/index.cgi/hg/file/6dcbe191a9b5/mercurial/osutil.py#l1
More information about the Mercurial-devel
mailing list