[PATCH 1 of 2] iss: take version from iscc command line
timeless
timeless at gmail.com
Mon Aug 17 07:10:41 UTC 2009
Steve Borho wrote:
> Inno Setup
> - http://www.jrsoftware.org/isinfo.php
> + http://www.jrsoftware.org/isdl.php#qsp
> +
> + Get ispack-5.3.4.exe, which includes Inno Setup Preprocessor,
> + which you must install.
I'm not a fan of "which you must install",
Get and install ispack-5.3.4.exe which includes Inno Setup Processor,
which is necessary to package Mercurial.
?
> Assuming it's on the path you run:
"Assuming it's in the path, you should execute:"
I'm aware you aren't changing this line, but I don't randomly read the
source repository, i read it by reading changes to it.
Some explanations
. path is a container, things are found in it, the fact that it is
checked sequentially by the shell isn't relevant to how it's used.
. you run programs, you don't run programs with arguments.
> +Where 'foo' is the version number you would like to see in the
> +'Add/Remove Applications' tool.
> The installer will output into an Output/ directory in your repository.
"The installer will be placed into a directory named "Output" in your
repository."
or instead of "in" you could use "at the root of".
More information about the Mercurial-devel
mailing list