bdiff stack overflow patch
Martin Geisler
mg at lazybytes.net
Tue Dec 8 21:42:34 UTC 2009
Benoit Boissinot <bboissin at gmail.com> writes:
> On Tue, Dec 8, 2009 at 8:23 PM, Alistair Bell <alistair at bellsonline.com> wrote:
>> Hi all,
>>
>> As mentioned in http://mercurial.selenic.com/bts/issue1940 I found
>> that I was getting a stack overflow in bdiff. You could possibly blame
>> GCC 3.4.6 for not recognizing that it should optimize the code as tail
>> recursion, but I converted the tail recursion to iteration and the
>> problems went away.
>
> Really gcc 3.4.6? Could you check if using the 4.x series has better results?
>
> Gcc 3.4 is really old, I'm not sure we should take the patch,
> especially given the code isn't tail-recursive, so it will stay
> recursive anyway.
You're saying that GCC 4.x would also have to output recursive code. Is
that not a good argument for why we *should* take the patch?
--
Martin Geisler
VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20091208/5df77b2a/attachment.asc>
More information about the Mercurial-devel
mailing list