[PATCH] Tweaks to subrepository-related output

Dan Villiom Podlaski Christiansen danchr at gmail.com
Thu Jun 18 09:28:33 UTC 2009


On 18/06/2009, at 10.46, Martin Geisler wrote:

> Dan Villiom Podlaski Christiansen <danchr at gmail.com> writes:
>
>> diff --git a/mercurial/commands.py b/mercurial/commands.py
>> --- a/mercurial/commands.py
>> +++ b/mercurial/commands.py
>> @@ -2300,6 +2300,13 @@
>>     URLs. If DESTINATION is omitted, a default path will be used.
>>     See 'hg help urls' for more information.
>>     """
>> +    # push subrepos depth-first for coherent ordering
>> +    c = repo['']
>> +    subs = c.substate # only repos that are committed
>> +    for s in sorted(subs):
>> +        if opts.get('rev'): raise NotImplementedError()
>
> I don't know why you raise this exception, but it should just be
> NotImplementedError without the parenthesis.

Erm, it was mainly because the revision isn't handled. Perhaps a  
warning would be better?

For what it's worth, I have update and pull (mostly) working locally :)

--

Dan Villiom Podlaski Christiansen
danchr at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1943 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20090618/6bf34900/attachment.p7s>


More information about the Mercurial-devel mailing list