[PATCH 1 of 2] extensions: extract descriptions at build time

Mads Kiilerich mads at kiilerich.com
Sun Jun 28 12:01:02 UTC 2009


Cédric Duval wrote, On 06/28/2009 12:00 PM:
> diff --git a/setup.py b/setup.py
> --- a/setup.py
> +++ b/setup.py
> @@ -161,6 +161,57 @@
>                                      ('install_lib', 'install_dir'))
>           install_data.finalize_options(self)
>
> +class build_extensions_list(build):
> +
> +    description = "build the list of Mercurial extensions"
> +    target = os.path.join('mercurial', '__extensions__.py')
>    

Names with leading and trailing double underscores are reserved by 
Python, so I think it would be best to avoid using them. See 
http://docs.python.org/reference/lexical_analysis.html#reserved-classes-of-identifiers

(__version__.py is already used by Mercurial, but it is a bad example. 
Especially when some standard libraries such as pydoc already buts 
special semantics into that name.)

/Mads






More information about the Mercurial-devel mailing list