[issue1866] util.copyfiles() fails on CIFS (Samba) filesystem

[bjoern]

New submission from bjoern <bjoern at shugaa.de>:

We're using Mercurial on Linux on a CIFS filesystem (a mounted Samba share
on a Windows XP server) which holds our repositories. This is the mount
commandline we're using:

mount -t cifs -o user=xyz,file_mode=0664,uid=1000,gid=100 //server/repo /mnt/smb

While Mercurial itself is working fine so far, I recently noticed that the
LocalBranch extension
(http://bitbucket.org/pk11/mercurial-extensions-localbranch/wiki/Home) fails
on filesystems which do not natively support links. Commits in one lbranch
end up in all lbranches.

lbranch uses Mercurial's util.copyfiles() utility method to do some of it's
magic, which in the end tries to copy using os.link hardlinking on Linux.
This seems to fail mysteriously on CIFS, rendering lbranch useless. Patching
util.copyfiles() to use shutil.copy() exclusively fixes the problem.

I'm not sure if this is a CIFS-, a Python-, or a Mercurial Problem.

mount.cifs version: 1.12-3.2.13
Mercurial Distributed SCM (version 1.3.1)

Regards

----------
messages: 10746
nosy: bjoern
priority: bug
status: unread
title: util.copyfiles() fails on CIFS (Samba) filesystem

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue1866>
____________________________________________________