[PATCH 1 of 2] util: state docstring of rename more precisely

Greg Ward greg-hg at gerg.ca
Wed Oct 7 20:19:35 UTC 2009


On Wed, Oct 7, 2009 at 4:11 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
> # HG changeset patch
> # User Adrian Buehlmann <adrian at cadifra.com>
> # Date 1254939403 -7200
> # Node ID 0a8a3f3fadbb925f0e28f716a5544b68d803709f
> # Parent  98feea5659d902bdca558ea7c9fed7670eb4f5e9
> util: state docstring of rename more precisely
>
> diff --git a/mercurial/util.py b/mercurial/util.py
> --- a/mercurial/util.py
> +++ b/mercurial/util.py
> @@ -400,7 +400,7 @@ def lexists(filename):
>     return True
>
>  def rename(src, dst):
> -    """forcibly rename a file"""
> +    '''atomically rename file src to dst, replacing dst if it exists'''

Isn't this patch rather pointless, given that you're about to move the
code in question wholesale?  Why not just rewrite the docstring in the
move-to-windows.py patch?

Greg




More information about the Mercurial-devel mailing list