[PATCH 4 of 4] transplant: add --merge-all and --merge-last

Adrian Buehlmann adrian at cadifra.com
Wed Oct 14 09:55:36 UTC 2009


On 14.10.2009 10:25, timeless wrote:
> On Wed, Oct 14, 2009 at 12:00 AM, Sune Foldager <cryo at cyanite.org> wrote:
[..]
> I'm sorry that I neglected to include the long detailed analysis of
> why the sentence was wrong. And I'm sorry if my original wording
> sounded harsh.
> 
> I'll go back to rewriting my employer's product strings (which are in
> general considerably worse than the ones here).
[..]

I think timeless' comments are in general correct.

Problem is, it is already difficult enough to get a patch in.

Believe me, I have often chosen not to send a patch
due to the painful process that this involves.

In one case I even decided to drop a whole issue
due to timeless' comments alone.

But even then, timeless was correct.

Sometimes though, it would be worthwhile to accept a patch,
even if it might contain some minor grammar errors.
Just to make *any* progress on an issue at last.

Commenting on a patch has the problem that people then
see it as "there are issues" with the patch, so it won't be
included.

Also, commenting on grammar errors or typos that happen to
be in a patch, but originate from preexisting code isn't
exactly helpful (I'm not talking about this patch here).

Not every grammar error is from the person sending
a patch.

As a side note, making harsh comments under a pseudonym
isn't exactly good taste. Is there any reason why you
can't stand by your stringent public opinions with your real
name?








More information about the Mercurial-devel mailing list