[PATCH 1 of 2] tests: unify test-patchbomb

[Christian Ebert]

* Martin Geisler on Tuesday, August 17, 2010 at 14:05:46 +0200
> Christian Ebert <blacktrash at gmx.net> writes:
>> Well, the test in question is about non-utf-8:
>> 
>> iso-8859-1 patch:
>>  $ python -c 'fp = open("isolatin", "wb"); fp.write("h\xF6mma!\n"); fp.close();'
>>  $ hg commit -A -d '5 0' -m 'charset=us-ascii; content-transfer-encoding: 8bit'
>>  adding isolatin
> 
> Yes, I know that. I know it's very practical and useful that we just
> pour the bytes into a mail and ship it off, even when the encoding is
> inconsistent in those bytes.

Well, the charset declaration of all patchbombs that contain
stuff that does not fit into ascii or utf-8 is just wrong.

That's why I was looking (in vain at the time) to implment
something like application/binary.

One other way I was thinking of was to automatically attach a
bundle in these cases. But then a bundle will only "apply" onto
the correct parent(s).

> I'm just saying that I'm not sure it's correct to do so. We had a recent
> bug report from Dan about not being able to send a patch that changed
> line-endings. I think this is the same kind of problem.

I imagine managing the interaction of eol.py and patchbomb as
another cosy sweet hell ;-)

c
-- 
Die Wolke Wolfgang
Eine Kindergeschichte mit Bildern. Von Michael Weber.
Das Buch   -->> http://www.blacktrash.org/baustellen/index.html#wolkewolfgang
Online     -->> http://www.blacktrash.org/wolkewolfgang/