[PATCH 2 of 2] mq/qqueue: enable renaming of active queue
Yann E. MORIN
yann.morin.1998 at anciens.enib.fr
Tue Aug 17 20:56:40 UTC 2010
Henrik, All,
On Tuesday 17 August 2010 21:47:59 Henrik Stuart wrote:
> On 15-08-2010 18:04, Yann E. MORIN wrote:
> > + if os.path.exists(newdir):
> > + raise util.Abort(_('existing patch directory for queue "%s"') % name)
> Perhaps 'directory "%s" already exists, but isn\'t a queue' would be a
> better wording?
Yes, it's better, but we shoud use newdir as the argument, instead of name.
Should I resubmit an updated version for this?
> All in all, I think the patches look fine and ready to be integrated.
Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the Mercurial-devel
mailing list