[PATCH 2 of 3] patchbomb: customize promptchoice to allow localization of choices

Christian Ebert blacktrash at gmx.net
Sat Aug 28 09:44:25 UTC 2010


* Christian Ebert on Saturday, August 28, 2010 at 01:03:42 +0100
> * Mads Kiilerich on Saturday, August 28, 2010 at 00:01:37 +0200
>> --diffstat apparently does something quite similar to what you
>> introduce with --confirm.
> 
> It asks for confirmation of the diffstat of each patch. 3 patches
> -> 3 prompts. confirm: 3 patches: 1 prompt. And, well, diffstat
> shows the diffstat, and confirm shows the message details,
> sender, recipients, subjects.
> 
>> What is your thoughts regarding that? Are both of them needed and do
>> they supplement each other? Could --diffstat be expanded instead of
>> introducing a new option - or should --diffstat be deprecated?
> 
> Frankly, I don't understand you there. Sorry.

In my eyes there's a fundamental difference between diffstat and
confirm, as diffstat changes the messages themselves. That's why
the 2 options only overlap by presenting a boolean prompt (and
diffstat does this for each patch as well for the whole series)
and not in their, errmh, content ... But I probably still don't
understand your question.

c
-- 
Die Wolke Wolfgang
Eine Kindergeschichte mit Bildern. Von Michael Weber.
Das Buch   -->> http://www.blacktrash.org/baustellen/index.html#wolkewolfgang
Online     -->> http://www.blacktrash.org/wolkewolfgang/



More information about the Mercurial-devel mailing list