[PATCH 0 of 3] Make hg serve --daemon work on Windows (issue421)

Nicolas Dumazet nicdumz at gmail.com
Thu Jan 28 09:23:20 UTC 2010


Hello!

We found out that test-inotify-issue1208 hangs after this serie.
"Boooo" on me for not running the inotify suite when reading about
that serie, even though I knew it could affect it. :/

I am not able to diagnose the issue. What happens, is that "hg st" in
the test, raises an expected util.Abort.
It blurts out from the line calling initfn() in cmdutil.service:

[...]
File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/mercurial/dispatch.py",
line 464, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
  File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/mercurial/util.py",
line 401, in check
    return func(*args, **kwargs)
  File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/hgext/inotify/__init__.py",
line 20, in serve
    server.start(ui, repo.dirstate, repo.root, opts)
  File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/hgext/inotify/server.py",
line 479, in start
    logfile=logfile, runargs=runargs, appendpid=appendpid)
  File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/mercurial/cmdutil.py",
line 603, in service
    initfn()
  File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/hgext/inotify/server.py",
line 454, in init
    self.master = master(ui, dirstate, root, timeout)
  File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/hgext/inotify/linuxserver.py",
line 431, in __init__
    timeout)
  File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/hgext/inotify/linuxserver.py",
line 397, in __init__
    server.socketlistener.__init__(self, ui, root, repowatcher, timeout)
  File "/home/nicdumz/tmp/hgtests.VMeXpx/install/lib/python/hgext/inotify/server.py",
line 341, in __init__
    raise util.Abort('inotify-server: cannot start: '

Again, that exception is expected, that is exactly what the test is looking for.

What I don't understand, however, is how a raise at this particular
spot stops "hg st" from returning.

Would you have any pointers here?

Thanks,

-- 
Nicolas Dumazet — NicDumZ



More information about the Mercurial-devel mailing list