[PATCH 4 of 4] patchbomb: display recipients and ask for confirmation

[Greg Ward]

On Thu, Jan 28, 2010 at 7:00 AM, Christian Ebert <blacktrash at gmx.net> wrote:
[me]
>> I agree with Mads: I
>> would like to see the exact "Subject" line along with "To" and "Cc".

[Christian]
> Only the first subject? All subjects? The latter sounds good, but
> might be confusing again.

Oh yeah.  Good point.  Hmmm.

> I'll experiment. One should keep in mind that the -n/--test
> option already exists. At least code-wise I see myself starting
> to replicate a lot of what it does already.

Yeah, but -n is too much information.  I've already carefully reviewed
the patches and commit message before emailing them.  Now I just want
to double check that I'm emailing what I meant to email.  E.g. if I
type "hg email -r -3:tip", is that *really* the correct range of
revisions?  I think that means I want to see *all* the subject lines.

> A prompt that comes up by default should be extremely short and
> concise.

Yes.  Maybe only show the subject lines (and "From"?) with -v?  I'll
get used to "hg email -v ..." if that's what I prefer.

And duplicating code is of course bad. You're the expert on patchbomb
right now, so I will certainly defer to you on what is feasible versus
what is desirable.  I'm just playing the role of "annoying user
griping from the sidelines about what he wants".  ;-)

Greg