[PATCH 0 of 2] patchbomb: ask for confirmation displaying summary of series

[Matt Mackall]

On Fri, 2010-01-29 at 20:20 +0000, Christian Ebert wrote:
> * Matt Mackall on Friday, January 29, 2010 at 13:44:31 -0600
> > On Fri, 2010-01-29 at 19:12 +0000, Christian Ebert wrote:
> >> * Matt Mackall on Friday, January 29, 2010 at 12:27:01 -0600
> >>> On Fri, 2010-01-29 at 16:55 +0000, Christian Ebert wrote:
> >>>> 1) Never prompt for cc, treat it like bcc
> >>> 
> >>> I don't really like this change. If I've used patchbomb for years
> >>> expecting it to give me a cc: prompt when I give no args, I'll be
> >>> bitten. I don't much like the interactive nature of patchbomb but my
> >>> earlier suggestion (skip cc: prompt when from: is given)
> >> 
> >> You mean: when to: is given?
> > 
> > Right.
> 
> Ok. Others were pointing out though that the ui is bad if it
> needs a table like this one:

That's a completely useless argument that's not at all to the merits of
the proposed (one-liner!) patch. Every function of n arguments is going
to have a table size that's exponential in n, whether the
specification/implementation for that function is one line or 100. The
table is not the implementation, folks, the table is an exhaustive set
of test cases to make sure your understanding of the proposal precisely
matches the implementer's.

> opts     hgrc     prompt   result
>                   new/old
> 
> to                NO/cc    to (opts)         *
> to       to       NO/cc    to (opts)         *
> to       cc       NO       to (opts), cc (hgrc)
> to       to, cc   NO       to (opts), cc (hgrc)
> 
> to, cc            NO       to (opts), cc (opts)
> to, cc   to       NO       to (opts), cc (opts)
> to, cc   cc       NO       to (opts), cc (opts)
> to, cc   to, cc   NO       to (opts), cc (opts)
> 
> cc                to       to (prompt), cc (opts)
> cc       to       NO       to (hgrc), cc (opts)
> cc       cc       to       to (prompt), cc (opts)
> cc       to, cc   NO       to (hgrc), cc (opts)
> 
>                   to, cc   to (prompt), cc (prompt)
>          to       cc       to (hgrc), cc (prompt)
>          cc       to       to (prompt), cc (hgrc)
>          to, cc   NO       to (hgrc), cc (hgrc)

Looks good.

-- 
http://selenic.com : development and support for Mercurial and Linux