[PATCH] EOL: Added filter aliases for backwards compatibility with win32text
Martin Geisler
mg at aragost.com
Wed Nov 17 10:10:55 UTC 2010
Colin Caughie <c.caughie at indigovision.com> writes:
>> Thanks, I pushed this as 278e3c9b939e and now I've just realized that
>> you missed the ':' in the end of the filter names :) I don't know
>> why, but the win32text extension declares the filters as
>> 'cleverencode:' and 'cleverdecode:'.
>>
>> Fix coming up...
>
> What's strange about this is that it worked for me without the ':'s.
> But putting the colons in definitely seems to be the right thing to do
> - sorry for missing that.
No problem :)
It also surprised me that it worked... A little investigation reveals
that it worked because when you say
[encode]
** = cleverencode:
in your config file, then localrepo will search for a declared filter so
that the config line starts with that filter. So any filter which is a
prefix of 'cleverencode:' will be used here.
The extra ':' is actually passed on to the filter as an extra argument.
This argument is quite conveniently ignored by the win32text filters.
--
Martin Geisler
aragost Trifork
Professional Mercurial support
http://mercurial.aragost.com/kick-start/
More information about the Mercurial-devel
mailing list