[PATCH 0 of 8] Move bookmarks extension to core

Augie Fackler durin42 at gmail.com
Wed Jan 19 17:37:46 UTC 2011


On Wed, Jan 19, 2011 at 6:47 AM, David Soria Parra <dsp at php.net> wrote:
> On 2011-01-18, Henrik Stuart <hg at hstuart.dk> wrote:
>> We should definitely allow non-ascii characters; I'd propose we do what
>> we do for branch names, plus a bit more, i.e., disallow "tip", ".", and
>> "null", and disallowing [\r\n\t\v\0] seems prudent as well, however,
>> both tag and branch just disallows (tip|\.|null) so that should be the
>> least that bookmarks disallows.
> make sense, I'll change this in the next iteration. I'll wait for more review before
> I reroll the series.

I'd also like to disallow : if nobody objects. It's illegal in git
refspecs (I believe) and it'd be useful for certain advanced features
(say, 'hg push -B foo:bar where you want foo to be renamed to bar on
the server). Does that seem reasonable?

>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>



More information about the Mercurial-devel mailing list