[PATCH 0 of 8] Move bookmarks extension to core

[Augie Fackler]

On Wed, Jan 19, 2011 at 12:28 PM, Pierre-Yves David
<pierre-yves.david at logilab.fr> wrote:
> On Wed, Jan 19, 2011 at 11:37:46AM -0600, Augie Fackler wrote:
>> On Wed, Jan 19, 2011 at 6:47 AM, David Soria Parra <dsp at php.net> wrote:
>> > On 2011-01-18, Henrik Stuart <hg at hstuart.dk> wrote:
>> >> We should definitely allow non-ascii characters; I'd propose we do what
>> >> we do for branch names, plus a bit more, i.e., disallow "tip", ".", and
>> >> "null", and disallowing [\r\n\t\v\0] seems prudent as well, however,
>> >> both tag and branch just disallows (tip|\.|null) so that should be the
>> >> least that bookmarks disallows.
>> > make sense, I'll change this in the next iteration. I'll wait for more review before
>> > I reroll the series.
>>
>> I'd also like to disallow : if nobody objects. It's illegal in git
>> refspecs (I believe) and it'd be useful for certain advanced features
>> (say, 'hg push -B foo:bar where you want foo to be renamed to bar on
>> the server). Does that seem reasonable?
>
> My vote probably doesn't weight much, but I'll be +1 for any proposition that
> help git/hg interoperability. That ease the jobs of bridge as hg-git and allow
> people to pick tools they prefer in each world.

Confession time: I also want this restriction because it'd make hgit
and hg-git way way easier.

>
> --
> Pierre-Yves David
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAk03LWUACgkQElczi7p/bN8bGACgp80hjQjGELatUaQheJ/HkV3c
> 9/kAnRoa7+69+iOcj1dJBHq/CQ/uHyqy
> =SA3b
> -----END PGP SIGNATURE-----
>
>