revert --all (again)

[Kevin Bullock]

On Jun 10, 2011, at 6:26 PM, Adrian Buehlmann wrote:

> On 2011-06-11 00:51, Matt Mackall wrote:
>> We're aborting because
>> we don't want people to accidentally lose all changes because they
>> fat-fingered the enter key.
> 
> But then, the current
> 
>  abort: no files or directories specified
> 
> is a red herring too.

Not really... if we're talking about fat-fingering the enter key before specifying the file(s) to revert.

> [...]
>  $ hg par -q
>  4:8765e19eea07
> 
>  $ hg revert -r 2
>  abort: reverting to revision 946c41063461 changes all files
>  (use update to check out that revision, or use --all to force)

I like this hint, but I'd favor keeping the current abort message. The fact that "no files or directories specified" seems totally unrelated to what the "newbie in danger" wants to do, namely check out a previous revision, to me provides a good warning flag that "this command, I do not think it does what you think it does."

pacem in terris / mir / shanti / salaam / heiwa
Kevin R. Bullock