[PATCH] A path is required to create a repository
Andrey
py4fun at gmail.com
Wed Nov 9 09:02:29 UTC 2011
> ...
>
> > -def repository(ui, path='', create=False):
> > +def repository(ui, path, create=False):
>
> This works as expected inside an existing repo:
>
> >>> from mercurial import ui, hg
> >>> ui = ui.ui()
> >>> r = hg.repository(ui)
>
> ..and your patch breaks that, so this is the wrong way to fix your
> problem.
>
1) there is no test to show this usage
2) there is no comment in the source to explain this usage
Since the patch does not solve any problem at all, it can be dropped. But a
comment in the code may prevent a possible confusion in the future.
-
Andrey
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20111109/5c4f8187/attachment-0002.html>
More information about the Mercurial-devel
mailing list