[PATCH RFC] hgweb: improve annotate flow

Laurens Holst laurens.nospam at grauw.nl
Fri Nov 18 18:55:12 UTC 2011


Op 18-11-2011 19:37, Patrick Mézard schreef:
> It actually exists but there is nothing to scroll so it gives the impression the anchor is not there. Just look for 'id="t1.372"' in the page source. That said, the anchor generation is a little ad-hoc and I would not be surprised to find bugs in this area with complicated patches mixing binaries and renames.
>
> Also, Javascript could be used here to highlight the target line or the target hunk and avoid this no-scroll issue (or even CSS if the id passed as a parameter as well).

Actually there’s an easier way to do this, without scripting; If you 
move the ID from the <a> tag to the <td> tag, you can use the CSS 
:target pseudo-class to highlight the line, something like:

td:target { background-color: yellow }

~Laurens

-- 
~~ Ushiko-san! Kimi wa doushite, Ushiko-san nan da!! ~~
Laurens Holst, developer, Utrecht, the Netherlands
Website: www.grauw.nl. Working @ www.roughcookie.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4332 bytes
Desc: S/MIME cryptografische ondertekening
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20111118/b8b4b81c/attachment.p7s>


More information about the Mercurial-devel mailing list