BUG: largefiles: lfconvert testcase

[Carter, Eli]

This patch adds a FAILING testcase that demonstrates a bug in the largefiles lfconvert tool: the standin files created by the conversion do not have the trailing newline they are supposed to have.  I haven't found a fix for that bug yet -- help would be appreciated.


Eli

# HG changeset patch
# User Eli Carter <eli.carter at tektronix.com>
# Date 1318961860 18000
# Branch stable
# Node ID 7d971e755d2d25cf426ad423d99ae9c2d0737f98
# Parent  56dbcfa77e25f19b7c0757d5a433775adf8ae43d
largefiles: failing testcase demonstrating bug

diff -r 56dbcfa77e25 -r 7d971e755d2d tests/test-largefiles.t
--- a/tests/test-largefiles.t   Tue Oct 18 11:09:11 2011 -0500
+++ b/tests/test-largefiles.t   Tue Oct 18 13:17:40 2011 -0500
@@ -443,3 +443,57 @@
   large6-modified
   $ cat sub2/large7
   large7
+  $ cd ..
+
+Convert appears to not add newlines, while other operations do?
+  $ hg init bigfile-repo
+  $ cd bigfile-repo
+  $ dd if=/dev/zero bs=1k count=10k > a-large-file 2> /dev/null
+  $ dd if=/dev/zero bs=1k count=23k > a-larger-file 2> /dev/null
+  $ echo "a small file" > a-small-file
+  $ echo "a tiny file" > a-tiny-file
+  $ hg addremove
+  adding a-large-file
+  adding a-larger-file
+  adding a-small-file
+  adding a-tiny-file
+  a-large-file: up to 31 MB of RAM may be required to manage this file
+  (use 'hg revert a-large-file' to cancel the pending addition)
+  a-larger-file: up to 72 MB of RAM may be required to manage this file
+  (use 'hg revert a-larger-file' to cancel the pending addition)
+  $ hg commit -m "Commit files without making them be largefiles"
+  $ find .hg/largefiles
+  .hg/largefiles
+  $ cd ..
+  $ hg lfconvert --size 10 bigfile-repo largefiles-repo
+  initializing destination largefiles-repo
+  $ cd largefiles-repo
+  $ find .hg/largefiles
+  .hg/largefiles
+  .hg/largefiles/8b0629c630f530cde051aeb42ce561756738fbe7
+  .hg/largefiles/8c206a1a87599f532ce68675536f0b1546900d7a
+  $ hg status
+  $ hg sum
+  parent: -1:000000000000  (no revision checked out)
+  branch: default
+  commit: (clean)
+  update: 1 new changesets (update)
+  $ hg up
+  4 files updated, 0 files merged, 0 files removed, 0 files unresolved
+  getting changed largefiles
+  2 largefiles updated, 0 removed
+  $ find .hglf
+  .hglf
+  .hglf/a-large-file
+  .hglf/a-larger-file
+  $ cat .hglf/*
+  8c206a1a87599f532ce68675536f0b1546900d7a
+  8b0629c630f530cde051aeb42ce561756738fbe7
+  $ dd if=/dev/zero bs=1k count=11k > another-large-file 2> /dev/null
+  $ hg add another-large-file
+  $ hg commit -m "Commit another file that should get automatically added as a largefile"
+  $ cat .hglf/*
+  8c206a1a87599f532ce68675536f0b1546900d7a
+  8b0629c630f530cde051aeb42ce561756738fbe7
+  187a0f76e02aac9c24f71c820be1f34ef1c76e76
+