[PATCH 05 of 12] phases: make _filterunknown a member function of phasecache

[Pierre-Yves David]

On Mon, Dec 17, 2012 at 11:12:46AM -0600, Kevin Bullock wrote:
> On Dec 17, 2012, at 9:35 AM, Idan Kamara wrote:
> > +    def filterunknown(self, repo):
> 
> This adds yet another method to the phasecache that takes a 'repo' argument. Would it be appropriate to make the constructor keep a handle on the repo?

That would need to be a weakref. And Matt does not like weakref[1].

-- 
Pierre-Yves David

http://www.logilab.fr/

[1] as in "hate them".

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20121217/b0176fb6/attachment.asc>