[PATCH 4 of 9] branchmap: read and write key part related to filtered revision

[Pierre-Yves David]

On 27 déc. 2012, at 17:56, Kevin Bullock wrote:

> On Dec 27, 2012, at 2:30 AM, Idan Kamara wrote:
> 
>> On Thu, Dec 27, 2012 at 1:53 AM, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>>> 
>>> 
>>> On 26 déc. 2012, at 22:09, Idan Kamara wrote:
>>> 
>>>> What will happen when an older client tries to use a newly
>>>> written cache?
>>> 
>>> That does not happen.
>>> 
>>> older client only tries to read `.hg/cache/branchheads`. This file
>>> contains the branchmap cache without any filtering applied. Therefore
>>> nothing is filtered and only tipnode and tiprev is written to disk exactly
>>> as the older format.
>>> 
>>> Cache for filtered version has they own file that older version won't try
>>> to read.
>> 
>> Reading this patch alone doesn't suggest that but I see
>> it's changed in the next couple of patches in this series.
> 
> Yeah, this patch should've come _after_ 5 and 7 in the series. Not a huge deal, but leaving open the chance of writing a branchcache file (with an hg at this changeset, but before the later ones in the series) that an older client can't read is suboptimal.

except nothing filtered is written to disk before #9.

-- 
Pierre-Yves