RFC: should we remind people to upgrade?
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Fri Dec 28 21:37:10 UTC 2012
On 28 déc. 2012, at 14:24, Arne Babenhauserheide wrote:
> Am Sonntag, 23. Dezember 2012, 14:31:32 schrieb Matt Mackall:
>> Here's one way to do that:
>>
>> - check the timestamp on __version__.py
>> - if > 6 months, report in 'hg version' and tracebacks
>>
>> $ touch -d "dec 1 2011" mercurial/__version__.py
>> $ hg version
>> Mercurial Distributed SCM (version 2.4.1+64-1c0dfd5f1357+20121222)
>> please upgrade!
>> (see http://mercurial.selenic.com for more information)
>>
>> Copyright (C) 2005-2012 Matt Mackall and others
>> This is free software; see the source for copying conditions. There
>> is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
>> PURPOSE.
>
> I don’t like relying on the timestamp. There are too many ways that it could
> change without affecting mercurial in any other way.
>
> Since we’re on a timebased scheme, it would be easy to reconstruct the
> creation date directly from the version string, so the shortcut through the
> timestamp looks like a brittle hack to me.
>
> Reconstructing the assumed current version from the version string would also
> document the release plan in code.
>
> I would propose the following:
Using the date of the lastest tag could work too.
--
Pierre-Yves
More information about the Mercurial-devel
mailing list