expectations from the community
Dirkjan Ochtman
dirkjan at ochtman.nl
Tue Feb 7 09:21:28 UTC 2012
On Tue, Feb 7, 2012 at 10:14, Andrey Somov <py4fun at gmail.com> wrote:
> My expectation: my job is done. The issue is known and those who know the
> code better and feel responsible may do whatever they wish
>
> What happens: the patch is rejected with comments that it should be
> improved. (Even though the reviewer can clear see the place to be improved
> !)
If your patch is meant as a demonstration of the issue, and not as a
patch meant to go into the codebase, you should probably not send it
to the mailing list as patchbomb. Instead, open an issue with a good
title describing the issue, describe the problem in the issue content,
and then include your patch in the issue, stating that it demonstrates
a possible fix. This way, you avoid raising the expectation that
you're going to see through the patch until it's included.
Hope that helps,
Dirkjan
More information about the Mercurial-devel
mailing list