expectations from the community

Dirkjan Ochtman dirkjan at ochtman.nl
Tue Feb 7 10:23:00 UTC 2012


On Tue, Feb 7, 2012 at 11:15, Andrey Somov <py4fun at gmail.com> wrote:
>  It is not the only one.  I totally agree with the review, but the question
> is general: why does anyone spend time on a review if it would be quicker
> and more efficient just to change it and apply to the code base ?

Your premise is wrong: review is much quicker than applying your patch
to the code base, verifying that the tests still pass and then pushing
it to one of the upstream repositories (i.e. crew).

> I did not quite catch you. Do you mean that the wiki shall say instead: "We
> do appreciate patches on the BTS" ?
>
> (By the way what BTS stands for ? I could find any explanation...)

BTS = Bug Ticket System, I think.

The wiki is wrong if you interpret it literally. Perhaps you (or
someone else could clarify it). The text in the wiki means that, if
you want to propose a patch for inclusion in the code base, you should
send it to the mailing list for review. If, as in your case, the patch
is not meant for inclusion but just to provide a better understanding
or demonstration of a perceived bug or feature, adding it to an issue
in the BTS is perfectly fine.

Or at least, that's the way I've interpreted the rules.

Cheers,

Dirkjan



More information about the Mercurial-devel mailing list