[PATCH RFC] commit: add --amend option to amend the parent changeset

Antoine Pitrou solipsis at pitrou.net
Mon Feb 20 16:29:13 UTC 2012


On Mon, 20 Feb 2012 17:19:44 +0100
Jason Harris <jason at jasonfharris.com> wrote:
> 
> To the user, the amend part is really associated with commit. It's doing the
> same thing.

To me as an user, it doesn't. Modifying is not the same as creating.
Actually, most software has "New document" and "Open document" as
separate (GUI) commands.

> Having to have a separate command for it is semantically wrong.
> Besides, in almost all the commands one uses options, eg maybe the -A
> (--addremove) to commit, or the -l (--limit) to log etc, etc.

I mostly use commit without options. I also often use log without
options (I have the pager extension enabled, so I don't have to
specify -l).

> Option use
> is a normal part of mercurial so the reasoning of "use a new command" instead of
> an "option" just doesn't wash for me.

Do you plan to introduce a short-hand for "--amend", at least?

> Besides, using new commands, instead of options would lead to combinatorial
> explosion.

Combinatorial explosion of what?

Regards

Antoine.



More information about the Mercurial-devel mailing list