[PATCH 0 of 1] Draw default branch on graph with colored bold line
Didly
didlybom at gmail.com
Wed Jan 11 08:30:15 UTC 2012
On Wed, Jan 11, 2012 at 4:10 AM, Constantine <theaspect at gmail.com> wrote:
> 1. I also agree. Soon I'll implement this and resend patch
> 2.a I've tested it: heads could be visually distinguished by markers color,
> so it's ok.
>
> 2012/1/10 Kevin Bullock <kbullock+mercurial at ringworld.org>
>>
>> On Jan 10, 2012, at 2:06 AM, Constantine wrote:
>>
>> Matt, I'm waiting for your feedback
>>
>>
>> I think there are two unresolved issues that need _discussion_ on-list,
>> and it seems to me that the ball's currently in your court:
>>
>> 1. Config syntax
>> 2. How to handle multiple (topological) heads on one (named) branch
>>
>> As to [1], I agree with Matt's refinement of my suggestion. (It matches
>> the way that e.g. external diff tools are configured.)
>>
>> I don't see any clarity yet on [2], so before you send another patch,
>> let's talk it out. For starters, what possibilities are we actually
>> considering?
>>
>> a. Making lines on entire default branch (including all heads) bold
>> b. Making only the line to the tipmost head on default branch bold
>> c. ???
>>
>> (b) has merit in the ability to tell visually which head you would get
>> from cloning. If we go that route we should also take into account the '@'
>> bookmark if it exists.
>>
>> Discuss!
>>
>> pacem in terris / мир / शान्ति / سَلاَم / 平和
>> Kevin R. Bullock
>>
>> 2012/1/7 Matt Mackall <mpm at selenic.com>
>>>
>>> On Fri, 2012-01-06 at 21:33 +0700, Constantine Linnick wrote:
>>> > graph: in hgrc specify line width and color of main branch
>>> >
>>> > You can specify width and, optionally, color to visually distinguish
>>> > main branch
>>> > (trunk) on hgweb's graph page. If color specified, all branch heads
>>> > will share
>>> > same color. Settings format is branch = width color, where width in px
>>> > and color
>>> > is six hexadecimal digits e.g. default = 2 FF0000.
>>>
>>> Sigh. Why are you sending me a patch?
>>>
>>> http://markmail.org/message/cmf3ypnsxbu4ryz6
>>>
>>> "I'll need to see a plan for that syntax before I can accept this."
>>> "I don't need an implementation, I need a discussion"
>>> "Again, what does the config syntax look like?"
>>>
>>> All you had to do was write something like this:
>>>
>>> Ok, how about like this?
>>>
>>> [graph]
>>> default=2 FF0000
>>>
>>> And then we could talk about it without you wasting any time coding it
>>> up!
>>>
>>> Kevin's suggestion is better, especially if we decide to add any more
>>> attributes, but I think I'd probably flip the branch name and attribute:
>>>
>>> [graph]
>>> default.color = FF0000
>>>
>>> I'd suggest calling this [web.graph] but perhaps Tortoise or other graph
>>> renderers will start using it.
>>>
>>> --
>>> Mathematics is the supreme nostalgia of our time.
Constantine,
it is customary on this list to type your replies at the bottom.
Personally I like the way TortoiseHg colors the graph. It uses the
same color for all the _nodes_ on the same named branch (and each
named branch gets its own color). Then it uses a different color for
each anonymous branch, even those that belong to the same named
branch.
Cheers,
Angel
More information about the Mercurial-devel
mailing list