[Bug 3485] New: <pre> inside <div> in map prevents styles showing correctly.

[bugzilla-daemon at bz.selenic.com]

http://bz.selenic.com/show_bug.cgi?id=3485

          Priority: normal
            Bug ID: 3485
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: <pre> inside <div> in map prevents styles showing
                    correctly.
          Severity: bug
    Classification: Unclassified
                OS: All
          Reporter: nevdelap at gmail.com
          Hardware: PC
            Status: UNCONFIRMED
           Version: 2.2.1
         Component: hgweb
           Product: Mercurial

Hi,

In templates/paper/map, because the <div> here...

diffblock = '<div class="source bottomline
parity{parity}"><pre>{lines}</pre></div>

...has the class "source" which applies a font-family, and the <pre> by default
uses whatever pres use (Courier New I guess), the fonts in the diff pages don't
show the font specified for the source class in the css.

A fix is to apply the classes to the <pre> and remove the <div>.

Here's the diff showing my map, against the default map, which I checked is
still the same in the tip of the Merurial repo.

$ diff map ../paper/map
79c79
< diffblock = '<pre class="source bottomline parity{parity}">{lines}</pre>'
---
> diffblock = '<div class="source bottomline parity{parity}"><pre>{lines}</pre></div>'

It makes it correctly apply the css and makes the fonts in the diff pages the
same as the fonts in the browsing files pages.

Thanks for the awesomeness of Mercurial, Best regards,

Nev

-- 
You are receiving this mail because:
You are on the CC list for the bug.