[PATCH] help: fix search with `-k` option in non-ASCII locales

Nikolaj Sjujskij sterkrig at myopera.com
Mon Jun 4 18:26:24 UTC 2012


Den 2012-06-04 19:32:53 skrev Josh Soref <timeless.bmo3 at gmail.com>:

> I think that you should probably  exclude or '' from here:
>> +        docs = _(getattr(entry[0], '__doc__', None) or '')
>
> docs = _(getattr(entry[0], '__doc__', None)) or ''

  Hm-m-m... Why? If `entry[0]` has no '__doc__', then `gettext` (imported  
as _) returns None, and non-string `docs` would break code below.



More information about the Mercurial-devel mailing list