[PATCH 2 of 2] test-walk: enable for Windows
Adrian Buehlmann
adrian at cadifra.com
Mon Jun 11 11:36:08 UTC 2012
On 2012-06-11 12:36, Mads Kiilerich wrote:
> On 11/06/12 11:24, Adrian Buehlmann wrote:
>> # HG changeset patch
>> # User Adrian Buehlmann<adrian at cadifra.com>
>> # Date 1339406116 -7200
>> # Node ID 436ea1d50a23c1019f163c643b3f758eca03ea9e
>> # Parent 5670fe8f8e3a63b18767ee38f55a14b847356e71
>> test-walk: enable for Windows
>>
>> diff --git a/tests/test-walk.t b/tests/test-walk.t
>> --- a/tests/test-walk.t
>> +++ b/tests/test-walk.t
>> @@ -1,5 +1,3 @@
>> - $ "$TESTDIR/hghave" no-windows || exit 80
>> -
>> $ hg init t
>> $ cd t
>> $ mkdir -p beans
>> @@ -14,7 +12,6 @@
>> $ echo fennel> fennel
>> $ echo fenugreek> fenugreek
>> $ echo fiddlehead> fiddlehead
>> - $ echo glob:glob> glob:glob
>> $ hg addremove
>> adding beans/black
>> adding beans/borlotti
>
> AFAICS this will remove a relevant existing test case on all platforms.
> I don't think that is acceptable unless there is a very good reason to
> do so. It must be possible to move the essentials of that test case to a
> separate section that can be #if guarded.
We can surely throw a handful of #if onto that, if you prefer.
However, this will cause duplication of a few lenghty blocks of output.
The bigger blocking issue on test-walk.t is the tons of backslashes in
the output (see my reply to patch 1).
More information about the Mercurial-devel
mailing list