[PATCH stable] findrepo(), walkrepos(): skip repositories not readable with current privileges; skip empty '.hg' directories, e.g. unmounted mountpoint

Adrian Buehlmann adrian at cadifra.com
Thu Jun 14 07:40:52 UTC 2012


On 2012-06-14 01:31, Martin Geisler wrote:
> (Minor detail: I read foo() as the result of calling foo, so if I want
> to talk about the function foo, I leave out the parenthesis.)

I just noticed that I seem to have that done differently myself.

Patrick seems to disagree with you as well? (e.g. 058e14da7044).

And the python docs use func() all over the place:

  http://docs.python.org/library/functions.html

Brodie appears to be in the func() camp too: e825a89de5d7.

Matt seems to not add "()", but off the top of my head I don't think I
saw him complaining about "func()" yet.

The example at:

http://mercurial.selenic.com/wiki/ContributingChanges#Patch_descriptions

has "... (lstat() returning 1...) ...", although not in the summary line.

Anyway, I think using func instead of func() in descriptions probably
makes sense. At least in the summary line. I'll try to adjust myself
accordingly.



More information about the Mercurial-devel mailing list