[PATCH 3 of 6] histedit: fix most check-code violations

Kevin Bullock kbullock+mercurial at ringworld.org
Thu Jun 28 15:29:56 UTC 2012


On Jun 28, 2012, at 8:59 AM, Augie Fackler wrote:

> # HG changeset patch
> # User Augie Fackler <raf at durin42.com>
> # Date 1340840133 18000
> # Node ID d7e7f85c32ac298a9e62ff4dab0ebaba0b82e96a
> # Parent  8c127c7e0c6dcd94e572cf72c64596d08ced4ea0
> histedit: fix most check-code violations
> 
> diff --git a/hgext/histedit.py b/hgext/histedit.py
> --- a/hgext/histedit.py
> +++ b/hgext/histedit.py
> [...]
> @@ -117,7 +115,7 @@
>             patch.patch(ui, repo, patchfile, files=files, eolmode=None)
>         finally:
>             os.unlink(patchfile)
> -    except Exception, inst:
> +    except Exception:
>         pass

Looks like this should be more specific? Or does it not matter since we just abort anyway? There's an awful lot of `except Exception:` happening in this code (but I'm sure that can be cleaned up after it's included, if need be).

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock




More information about the Mercurial-devel mailing list