[PATCH 6 of 6] commit: add option to amend the working dir parent

Idan Kamara idankk86 at gmail.com
Wed Mar 7 13:45:54 UTC 2012


On Wed, Mar 7, 2012 at 10:24 AM, Gilles Moris <gilles.moris at free.fr> wrote:

> On Tuesday 06 March 2012 05:44:29 pm Idan Kamara wrote:
> > +    if opts.get('amend'):
>
> Size of the if "--amend" option code: more than 150 lines
>

It's a lot less than that because a big part of it are comments
and me being generous with new lines.


> Size of the else (standard commit) code: around 20 lines
>
> That's still pleading for a separate command.
> At least, this "amend" part shall probably be extracted out so that the
> commit
> code remains readable.


I was thinking of moving it to cmdutil.amend, or maybe there's
a better place for it. I'll wait for more comments though.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20120307/3dd3099d/attachment-0002.html>


More information about the Mercurial-devel mailing list