[PATCH] win32mbcs: add reversing wrapper for some unicode-incompatible functions
Matt Mackall
mpm at selenic.com
Wed Oct 17 17:29:19 UTC 2012
On Wed, 2012-10-17 at 18:34 +0900, Shun-ichi Goto wrote:
> 2012/10/17 Matt Mackall <mpm at selenic.com>:
> >> win32mbcs: add reversing wrapper for some unicode-incompatible functions.
> >
> > Looks like we're waiting on a cleaned-up version of this following
> > foozy's review.
>
> Sorry for bothering you, I had forgot sending modified version.
>
> > My take is that this is a bit too hard to read. Something like this
> > would be better:
>
> OK, I've taken your suggestion and code sample (with some typo fix).
> Send new patch in another email.
>
> By the way, there is an another solution by making encoding.lower() and upper()
> unicode compatible. With this change, current win32mbcs.py works correctly.
> Is this better?
No, because unicode objects are outlawed in the Mercurial internal API.
--
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial-devel
mailing list