[PATCH 1 of 2] amend: add noise in extra to avoid creating obsolescence cycle (issue3664)

Augie Fackler raf at durin42.com
Thu Oct 18 16:16:19 UTC 2012


On Thu, Oct 18, 2012 at 11:13 AM, Kevin Bullock
<kbullock+mercurial at ringworld.org> wrote:
> On Oct 18, 2012, at 11:03 AM, pierre-yves.david at logilab.fr wrote:
>

>> +            extra['amend-from'] = old.hex()
>
> Consistency with graft, transplant, and rebase would dictate that this key should be named 'amend_source'. At least switching to an underscore would be nice.

Agreed. amend_source.

>
> Other than that, LGTM.
>
> pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
> Kevin R. Bullock
>



More information about the Mercurial-devel mailing list