[PATCH STABLE] clone: show status "updating to bookmark @"

Adrian Buehlmann adrian at cadifra.com
Mon Oct 29 00:51:34 UTC 2012


On 2012-10-27 09:39, Thomas Arendsen Hein wrote:
> Do you intentionally print "updating to bookmark X" only, if the
> bookmark is automatically selected (i.e. "@"), not for bookmarks
> specified by e.g. -u?

(I haven't answered this yet because I needed to think about this some
more before answering)

Good question.

It was not that intentional, but I think it is good as I did it.

The help of clone for -u says:

 -u --updaterev REV     revision, tag or branch to check out

Let's say we have a tag X that happens to refer to the same revision as
the @ bookmark and we specified '-u X'.

Would we then want to see "updating to bookmark @"? I'd say no.

Next question is: what if the user says "-u @"?

I'd still say no, because the @ has been "converted" to a revision by
the lookup logic, and the user just specified a specific revision to
update to. That revision just happens to be the one @ refers to.

But I think if we wanted we *could* detect "-u @" and treat that as
equivalent. But I think it is ok if we don't do that.



More information about the Mercurial-devel mailing list