[PATCH] smtp: use 465 as default port for SMTPS

[Matt Mackall]

On Thu, 2013-04-18 at 12:39 -0500, Kevin Bullock wrote:
> On 18 Apr 2013, at 12:08 PM, FUJIWARA Katsunori wrote:
> 
> > # HG changeset patch
> > # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> > # Date 1366302383 -32400
> > #      Fri Apr 19 01:26:23 2013 +0900
> > # Node ID fa1246e1b7453276ca71fb4349e4fac5a2473dff
> > # Parent  7d31f2e42a8afb54c8fae87e8e3e29a63578aea4
> > smtp: use 465 as default port for SMTPS
> > 
> > Before this patch, port 25 (wellknown port of SMTP) is used as default
> > port, even if "[smtp] tls" is configured as "smtps".
> > 
> > This patch uses port 465 (wellknown port of SMTPS) as default port, if
> > "[smtp] tls" is configured as "smtps".
> 
> This is arguably a bug, but would also break backward compatibility in
> a 3-year-old feature. Our documented default port setting is 25,
> independent of the 'tls' setting.

SSMTP is much like HTTPS: it starts an SSL connection immediately with
no negotiation. Thus, if you try to speak SSMTP on the SMTP port, you
will fail (and vice versa). 

So the only people for whom this would be a regression are people who've
configured their SMTP servers to be incompatible with the rest of the
internet.

-- 
Mathematics is the supreme nostalgia of our time.